[JENKINS-71047] Deprecate inline JS event handlers#8061
Merged
timja merged 5 commits intojenkinsci:masterfrom Aug 15, 2025
Merged
[JENKINS-71047] Deprecate inline JS event handlers#8061timja merged 5 commits intojenkinsci:masterfrom
timja merged 5 commits intojenkinsci:masterfrom
Conversation
timja
reviewed
May 29, 2023
| <st:attribute name="value" /> | ||
| <st:attribute name="id" /> | ||
| <st:attribute name="onclick" /> | ||
| <st:attribute name="onclick" deprecated="true">onclick handler. Deprecated; assign an ID and look up the element that way to attach event handlers.</st:attribute> |
Member
There was a problem hiding this comment.
may be better to use class name as repeatable elements don't work properly with IDs from what I remember.
IDs are safe to use in standalone pages / configuration forms that won't be used in repeatable elements
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Member
|
This was resolved in another PR which addressed this more fully. |
Member
| remain undocumented even after #10941. |
timja
approved these changes
Aug 13, 2025
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Member
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
None.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).New public classes, fields, and methods are annotated with@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).For dependency updates, there are links to external changelogs and, if possible, full differentials.For new APIs and extension points, there is a link to at least one consumer.Desired reviewers
@jenkinsci/core-security-review
Maintainer checklist
Before the changes are marked as
ready-for-merge:upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).